Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/exportertest] - Make exportertest into its own module #11489

Merged
merged 8 commits into from
Oct 21, 2024
Merged

[exporter/exportertest] - Make exportertest into its own module #11489

merged 8 commits into from
Oct 21, 2024

Conversation

VihasMakwana
Copy link
Contributor

Resolves #11461

@codecov Codecov
Copy link

codecov bot commented Oct 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.47%. Comparing base (f2b31d1) to head (c40b530).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11489      +/-   ##
==========================================
- Coverage   91.48%   91.47%   -0.02%     
==========================================
  Files         433      433              
  Lines       23617    23617              
==========================================
- Hits        21607    21604       -3     
- Misses       1642     1645       +3     
  Partials      368      368

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VihasMakwana VihasMakwana marked this pull request as ready for review October 19, 2024 18:30
@VihasMakwana VihasMakwana requested a review from a team as a code owner October 19, 2024 18:30
@bogdandrutu
Copy link
Member

This needs a rebase

@VihasMakwana
Copy link
Contributor Author

VihasMakwana commented Oct 21, 2024 •
edited
Loading

@bogdandrutu @mx-psi CI is green. looks good to be merged.

@bogdandrutu bogdandrutu merged commit 3193106 into open-telemetry:main Oct 21, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner automatically assigned from open-telemetry/collector-approvers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.112.0
Development

Successfully merging this pull request may close these issues.

Make exportertest into its own module
2 participants
@VihasMakwana @bogdandrutu